Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Treelite 1.0.0 stable #210

Merged
merged 1 commit into from
Jan 25, 2021

Conversation

hcho3
Copy link
Contributor

@hcho3 hcho3 commented Jan 21, 2021

The 1.0.0 stable version of Treelite is virtually identical to the 1.0.0 RC1 version, so I don't expect any code to break.

Copy link
Member

@ajschmidt8 ajschmidt8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blocking this until the new treelite version is tested in cuml. See below comment for details.

rapidsai/cuml#3394 (comment)

@hcho3
Copy link
Contributor Author

hcho3 commented Jan 23, 2021

Can we merge this, now that rapidsai/cuml#3394 is passing the test with the latest Treelite?

@ajschmidt8 ajschmidt8 merged commit 89aa2ec into rapidsai:branch-0.18 Jan 25, 2021
@ajschmidt8
Copy link
Member

@hcho3, done!

@hcho3 hcho3 deleted the upgrade_treelite branch January 25, 2021 23:33
rapids-bot bot pushed a commit to rapidsai/cuml that referenced this pull request Jan 30, 2021
The stable 1.0.0 version of Treelite is [virtually identical to the 1.0.0 RC1 version](dmlc/treelite#246). Using `1.0.0rc1|1.0.0` so that the CI doesn't break until rapidsai/integration#210 is merged.

Authors:
  - Philip Hyunsu Cho (@hcho3)

Approvers:
  - AJ Schmidt (@ajschmidt8)

URL: #3394
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants